Open
Conversation
5 tasks
MKodde
reviewed
Nov 3, 2025
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Nice work! We had a small discussion IRL where I questioned the current solution:
- Could you make a more 'generic' solution for the object and array types that you now added. This would need to include passing the type of the array items that are stored for additional type checking. And maybe passing a max length as some types have different requirements for that..
- Keep the current setup but add some additional (unit or integration) tests. I've found a couple of unit tests for two of the existing types
Question: are the types used in the existing functional tests? Or are they bypassed by the custom mock solution?
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
2 times, most recently
from
805c922 to
271256a
Compare
johanib
commented
Feb 9, 2026
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
from
271256a to
cb43e68
Compare
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
from
cb43e68 to
fdc995d
Compare
johanib
commented
Feb 10, 2026
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
from
fdc995d to
84b50bb
Compare
kayjoosten
reviewed
Feb 11, 2026
kayjoosten
approved these changes
Feb 13, 2026
kayjoosten
requested changes
Feb 13, 2026
Contributor
kayjoosten
left a comment
kayjoosten
left a comment
There was a problem hiding this comment.
Test are still failing
github-project-automation
bot
moved this from In Progress
to Backlog
in PHP development
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
from
6f86ba5 to
074c48f
Compare
kayjoosten
approved these changes
Feb 26, 2026
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
4 times, most recently
from
b019847 to
29b6168
Compare
Contributor
Author
|
kayjoosten
approved these changes
Feb 26, 2026
MKodde
reviewed
Feb 26, 2026
johanib
commented
Feb 26, 2026
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
3 times, most recently
from
17fbd2f to
dbadae3
Compare
johanib
commented
Feb 26, 2026
- The old array / object serialization types from doctrine have been moved / integrated into our codebase for backward compatability. - Fix typo in allowed_idp_entity_ids. The db is a medium text, which is 16777215 bytes. This change aligns the column with the mapping. - Make the nullable: false explicit to avoid future confusion. Confusion could stem from the fact that the fields are nullable in code, but not nullable in the database. This is because a serialized `null` results in something like `s:` in the database.
johanib
force-pushed
the
feature/update_dbal_4_1799_3
branch
from
dbadae3 to
b83392f
Compare
Contributor
Author
|
My earlier comparison was not correct. Doctrine does in fact want to remove the comments, and migrate longtext columns to json. In this PR, I reinstated the length limits so the correct column types are used matching prod. The nulls are also fixed. |
kayjoosten
reviewed
Feb 27, 2026
| #[Test] | ||
| public function an_object_round_trips_correctly(): void | ||
| { | ||
| $type = Type::getType(SerializedObjectType::NAME); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for SF 6.4