Strip hyperobject wrapper when evaluating c++14 constexpr constructor#419
Open
VoxSciurorum wants to merge 1 commit intoOpenCilk:dev/21.xfrom
Open
Strip hyperobject wrapper when evaluating c++14 constexpr constructor#419VoxSciurorum wants to merge 1 commit intoOpenCilk:dev/21.xfrom
VoxSciurorum wants to merge 1 commit intoOpenCilk:dev/21.xfrom
Conversation
Collaborator
|
Can you add a Cilk regression test for this change? |
VoxSciurorum
force-pushed
the
jfc/constexpr
branch
from
8c03f9c to
9ad1df8
Compare
VoxSciurorum
changed the title
Contributor
Author
|
I added a test case. It is simple but reducing to get it took time. |
VoxSciurorum
force-pushed
the
jfc/constexpr
branch
from
9ad1df8 to
a705dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialization of a reducer where the underlying object has a
constexprconstructor can cause crashes when the type of theDecldoes not match the type of the initializer.The better approach may be to suppress
constexprprocessing in such cases becauseconstexprreducers do not make sense.