Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add support for dynamic configurable required fields to Events #8960

Open
wants to merge 1 commit into
base: release/6.4.0
Choose a base branch
from

Conversation

VerboseCat
Copy link
Contributor

@VerboseCat VerboseCat commented Nov 8, 2024

Proposed changes

This PR builds upon the capabilities from #6972. This PR will add all capabilities from the previous PR to the 'Events' section of the platform, to include creating and editing the following entity types:

  • Incidents
  • Observed Data
  • Sightings

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • (N/A - Existing test cases should work properly) I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • The customization menu for 'Observed Data' includes a 'Content' field, but there is no 'Content' field in either the create or edit form, so requiring this field makes it impossible to submit the form.

  • Incident and Observed Data creation forms include the field objectLabel but the edit forms do not. This field is not in the 'Customization' menu. Adding it would break the edit forms.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.60%. Comparing base (2c1be7f) to head (fe159a9).

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #8960      +/-   ##
=================================================
+ Coverage          64.59%   64.60%   +0.01%     
=================================================
  Files                614      614              
  Lines              58902    58902              
  Branches            6476     6477       +1     
=================================================
+ Hits               38046    38053       +7     
+ Misses             20856    20849       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard added the community use to identify PR from community label Nov 12, 2024
Add required fields to Observed Data

Add required fields to Sightings
@frapuks frapuks self-requested a review November 14, 2024 13:38
@frapuks frapuks self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants