[backend] use component name in traces and fix warn issue.(#8352)(#8310) #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aHenryJard
commented
Oct 7, 2024
opencti-platform/opencti-graphql/src/manager/playbookManager.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
filigran team
aHenryJard
commented
Oct 7, 2024
opencti-platform/opencti-graphql/src/modules/playbook/playbook-domain.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8625 +/- ##
==========================================
+ Coverage 65.93% 65.97% +0.03%
==========================================
Files 597 597
Lines 60694 60720 +26
Branches 6201 6229 +28
==========================================
+ Hits 40021 40057 +36
+ Misses 20673 20663 -10 ☔ View full report in Codecov by Sentry. |
| @@ -110,7 +110,7 @@ const PLAYBOOK_LOGGER_COMPONENT_SCHEMA: JSONSchemaType<LoggerConfiguration> = { | |||
| oneOf: [ | |||
| { const: 'debug', title: 'debug' }, | |||
| { const: 'info', title: 'info' }, | |||
| { const: 'warning', title: 'warning' }, | |||
| { const: 'warn', title: 'warn' }, | |||
There was a problem hiding this comment.
Seems ok but I don't know how to test this part?
There was a problem hiding this comment.
you need a component
if you test on master with 'warning', you will see an error in console log of opencti, when using this fix the bundle is in log with warn level.
| @@ -157,7 +157,7 @@ export const playbookExecutor = async ({ | |||
| const durationDiff = end.diff(start); | |||
| const duration = moment.duration(durationDiff); | |||
| const observation: ObservationFn = { | |||
| message: `${nextStep.component.name.trim()} successfully executed in ${duration.humanize()}`, | |||
| message: `${nextStep.instance.name.trim()} successfully executed in ${duration.humanize()}`, | |||
marieflorescontact
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments