Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Use ID instead of label when resolving expectation from OpenBAS #8589

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Oct 3, 2024

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 65.97%. Comparing base (cde8568) to head (4235bfa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...-platform/opencti-graphql/src/database/xtm-obas.ts 24.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8589      +/-   ##
==========================================
+ Coverage   65.94%   65.97%   +0.03%     
==========================================
  Files         597      597              
  Lines       60701    60678      -23     
  Branches     6202     6204       +2     
==========================================
+ Hits        40028    40032       +4     
+ Misses      20673    20646      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumejparis
Copy link
Member

What about PARTIAL ? not in counters ?

OpenBAS-Platform/openbas@ab25dcf/openbas-api/src/main/java/io/openbas/expectation/ExpectationType.java#L15

From my comprehension we do not use PARTIAL in this case

@guillaumejparis guillaumejparis merged commit af10c8c into master Oct 7, 2024
6 checks passed
@guillaumejparis guillaumejparis deleted the issue/1608 branch October 7, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results of OpenBAS scenarios are not displayed anymore in OpenCTI
6 participants