Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Add SAML option to get email from attribute (#8536) #8537

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

richard-julien
Copy link
Member

See #8536

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 29, 2024
@richard-julien richard-julien linked an issue Sep 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.42%. Comparing base (9754a5e) to head (7f263c4).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...i-platform/opencti-graphql/src/config/providers.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8537      +/-   ##
==========================================
+ Coverage   66.21%   66.42%   +0.20%     
==========================================
  Files         597      597              
  Lines       60417    60549     +132     
  Branches     6205     6447     +242     
==========================================
+ Hits        40008    40221     +213     
+ Misses      20409    20328      -81     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard self-assigned this Oct 2, 2024
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a SAML/keycloak working as expected. All good !

@aHenryJard
Copy link
Member

linked to OpenCTI-Platform/docs#213

@aHenryJard aHenryJard merged commit 18603fa into master Oct 3, 2024
6 checks passed
@aHenryJard aHenryJard deleted the issue/8536 branch October 28, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Add SAML option to get email from attribute
2 participants