[backend] add 'unauthorized' in event scope filter values (#8414) #8417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archidoit
force-pushed
the
issue/8414
branch
from
08687d6
to
4bc16c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8417 +/- ##
==========================================
+ Coverage 66.13% 66.19% +0.06%
==========================================
Files 597 597
Lines 60382 60387 +5
Branches 6192 6193 +1
==========================================
+ Hits 39935 39975 +40
+ Misses 20447 20412 -35 ☔ View full report in Codecov by Sentry. |
| @@ -31,7 +31,7 @@ const HistoryDefinition: AttributeDefinition[] = [ | |||
| { name: 'event_type', label: 'Event type', type: 'string', format: 'enum', values: ['authentication', 'read', 'mutation', 'file', 'command'], editDefault: false, mandatoryType: 'internal', multiple: false, upsert: false, isFilterable: true }, | |||
| { name: 'event_status', label: 'Event status', type: 'string', format: 'enum', values: ['error', 'success'], editDefault: false, mandatoryType: 'internal', multiple: false, upsert: false, isFilterable: false }, | |||
| { name: 'event_access', label: 'Event access', type: 'string', format: 'enum', values: ['extended', 'administration'], editDefault: false, mandatoryType: 'internal', multiple: false, upsert: false, isFilterable: false }, | |||
| { name: 'event_scope', label: 'Event scope', type: 'string', format: 'enum', values: ['create', 'update', 'delete', 'read', 'search', 'enrich', 'download', 'import', 'export', 'login', 'logout'], editDefault: false, mandatoryType: 'internal', multiple: false, upsert: false, isFilterable: true }, | |||
| { name: 'event_scope', label: 'Event scope', type: 'string', format: 'enum', values: ['create', 'update', 'delete', 'read', 'search', 'enrich', 'download', 'import', 'export', 'login', 'logout', 'unauthorized'], editDefault: false, mandatoryType: 'internal', multiple: false, upsert: false, isFilterable: true }, | |||
There was a problem hiding this comment.
Oh, I didn't know we had to list the values like this in the attribute definition for static enums. I guess it will fix this specific issue, but I wonder if we shouldn't think of another approach to make sure we maintain correctly this list.
There was a problem hiding this comment.
at least put it in a constant EVENT_SCOPE_VALUES = [..] ?
There was a problem hiding this comment.
if so, it means we put every enum filters in constants.... (event access, event type, event status, maximum retention unit, file scope etc)
Archidoit
force-pushed
the
issue/8414
branch
from
f8f901e
to
a9e61e0
Compare
labo-flg
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the 'unauthorized' value in event scope files (in Settings > Activity)
Related issues
#8414