Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] center loader (#8280) #8386

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[frontend] center loader (#8280) #8386

merged 1 commit into from
Sep 19, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Sep 17, 2024

Proposed changes

  • center loader

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Sep 17, 2024
@frapuks frapuks self-assigned this Sep 17, 2024
@Archidoit
Copy link
Member

Behavior and code ok but maybe need to rebase for the Drone tests

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (c986eae) to head (bffaaea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8386   +/-   ##
=======================================
  Coverage   66.13%   66.14%           
=======================================
  Files         597      597           
  Lines       60382    60382           
  Branches     6190     6192    +2     
=======================================
+ Hits        39935    39937    +2     
+ Misses      20447    20445    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks merged commit 68efd7f into master Sep 19, 2024
6 checks passed
@frapuks frapuks deleted the issue/8280 branch September 19, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader in knowledge graph should be position at center vertically, not at the top
2 participants