[frontend] fixed workbench creation pop-up in case of error (#8265) #8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8285 +/- ##
==========================================
- Coverage 66.23% 66.21% -0.02%
==========================================
Files 597 597
Lines 60300 60422 +122
Branches 6196 6202 +6
==========================================
+ Hits 39939 40009 +70
- Misses 20361 20413 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kedae
requested changes
Sep 8, 2024
| @@ -130,6 +134,11 @@ const WorkbenchFileCreator: FunctionComponent<WorkbenchFileCreatorProps> = ({ | |||
| handleCloseCreate(); | |||
| onCompleted?.(); | |||
| }, | |||
| onError: () => { | |||
| setSubmitting(false); | |||
There was a problem hiding this comment.
As this code is shared between multiple places (onCompleted, onError, twice). I suggest to extract it into a "handleCompleted" or something like that method.
SamuelHassine
force-pushed
the
master
branch
from
f8359b7
to
558e6c1
Compare
Kedae
approved these changes
Sep 24, 2024
|
@stefan1anuby You need to sign your commits, can you check GCP to sign your commits ? |
…Platform#8265) Signed-off-by: stefan1anuby <stefaneduard2002@gmail.com>
Signed-off-by: stefan1anuby <stefaneduard2002@gmail.com>
stefan1anuby
force-pushed
the
issue/8265
branch
from
51d7e4b
to
7014bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If I hadn't set that generic error, the message would have been:
"RRNLRequestError: Relay request for WorkbenchFileCreatorMutation failed for the following reason: 1. A file already exists with this name. uploadPending(file: $file, labels: $labels, errorOnExistin ^^^"
Would this be too confusing for users?
Related issues
part of #8265
Checklist
Further comments
Should I implement form validation to check for duplicate workbench names when the "Create" button is pressed? Doing so would allow us to display a more specific error message, such as "A file with this name already exists."