Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] display alias value in place of alias label in form field (#8053) #8130

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Aug 21, 2024

Proposed changes

  • use value in place of label to remove the createLabel in Chip after the selection

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • The createLabel is still used on the dropdown menu to differenciate actual and new values

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Aug 21, 2024
@frapuks frapuks self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (62049d4) to head (fea4b0b).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8130      +/-   ##
==========================================
+ Coverage   67.74%   67.92%   +0.17%     
==========================================
  Files         574      585      +11     
  Lines       71123    71139      +16     
  Branches     6058     6149      +91     
==========================================
+ Hits        48182    48318     +136     
+ Misses      22941    22821     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe
Copy link
Member

CelineSebe commented Aug 21, 2024

Add string always displays in the input:

image

@frapuks
Copy link
Member Author

frapuks commented Aug 22, 2024

yes, it's deliberate, because from the way the code was done, I think it was to differentiate, in the drop-down menu, the current labels from the new ones, thanks to this createLabel Add.
On the other hand, this createLabel Add was displayed in the Chip component that was created in the form field after selection, and that was what needed to be removed.
image

@CelineSebe
Copy link
Member

yes, it's deliberate, because from the way the code was done, I think it was to differentiate, in the drop-down menu, the current labels from the new ones, thanks to this createLabel Add. On the other hand, this createLabel Add was displayed in the Chip component that was created in the form field after selection, and that was what needed to be removed. !

Ok, with the explanation

@frapuks frapuks merged commit b19fe9f into master Aug 22, 2024
5 checks passed
@frapuks frapuks deleted the issue/8053 branch August 22, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Taxonomies] Problem adding aliases to open vocab
2 participants