Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Dashboard refacto - split view between dashboard and public dashboards #7702

Merged
merged 56 commits into from
Aug 19, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Jul 15, 2024

Proposed changes

  • left menu: split access view beetween dashboards and public dashboards
  • new list with data tables for public dashboards
  • rework publicDashboard API to return only the ones I can see
  • add actions panel in publi dashboard line (copy link, disabled/enabled, delete (with correct "Can manage" or to be the dashboard creator)
  • addition of column shared/not shared in dashboard
  • add redirection with "view associated public dashboards", "Go to dashboard"
  • br under feature flag

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Jul 15, 2024
@CelineSebe CelineSebe self-assigned this Jul 15, 2024
@CelineSebe CelineSebe force-pushed the issue/6509-refacto-chunk1 branch 3 times, most recently from 34f725d to 1ff41b9 Compare July 22, 2024 12:29
@CelineSebe CelineSebe force-pushed the issue/6509-refacto-chunk1 branch 2 times, most recently from dace025 to e63f9c2 Compare July 24, 2024 15:18
@CelineSebe CelineSebe added this to the Release 6.3.0 milestone Jul 24, 2024
@CelineSebe CelineSebe force-pushed the issue/6509-refacto-chunk1 branch 2 times, most recently from 0f644bb to 1a8c154 Compare July 25, 2024 13:12
@SamuelHassine SamuelHassine removed this from the Release 6.3.0 milestone Jul 28, 2024
@CelineSebe CelineSebe force-pushed the issue/6509-refacto-chunk1 branch 3 times, most recently from 6f958d8 to 5474287 Compare July 30, 2024 06:40
@CelineSebe CelineSebe added this to the Release 6.3.0 milestone Jul 30, 2024
@CelineSebe CelineSebe force-pushed the issue/6509-refacto-chunk1 branch 4 times, most recently from 919694b to 305e71d Compare July 31, 2024 07:04
@lndrtrbn lndrtrbn force-pushed the issue/6509-refacto-chunk1 branch 2 times, most recently from 29a4de4 to a686647 Compare August 1, 2024 13:40
@CelineSebe CelineSebe force-pushed the issue/6509-refacto-chunk1 branch 2 times, most recently from c3fd859 to c24fe1b Compare August 2, 2024 14:55
@lndrtrbn lndrtrbn force-pushed the issue/6509-refacto-chunk1 branch 2 times, most recently from 244d114 to 6869a44 Compare August 6, 2024 09:51
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 73.41772% with 42 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (4c0dd26) to head (5004112).
Report is 2 commits behind head on master.

Files Patch % Lines
...platform/opencti-graphql/src/domain/basicObject.ts 43.10% 33 Missing ⚠️
...c/modules/publicDashboard/publicDashboard-utils.ts 76.47% 4 Missing ⚠️
...rm/opencti-graphql/src/schema/schema-attributes.ts 50.00% 4 Missing ⚠️
.../modules/publicDashboard/publicDashboard-domain.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7702      +/-   ##
==========================================
+ Coverage   67.72%   67.74%   +0.01%     
==========================================
  Files         572      574       +2     
  Lines       71041    71123      +82     
  Branches     6045     6058      +13     
==========================================
+ Hits        48114    48182      +68     
- Misses      22927    22941      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe marked this pull request as ready for review August 8, 2024 14:44
@Archidoit
Copy link
Member

Archidoit commented Aug 8, 2024

Differences in navigation headers between custom and public dashboards (no path for Custom dashboards) :

image

image

@lndrtrbn lndrtrbn merged commit 5061a4f into master Aug 19, 2024
5 checks passed
@SamuelHassine SamuelHassine removed this from the Release 6.3.0 milestone Aug 20, 2024
@CelineSebe CelineSebe deleted the issue/6509-refacto-chunk1 branch August 20, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants