Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix e2e stix data and add extended error to CI (#7611) #7612

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jul 5, 2024

Proposed changes

  • Update stix id that does not exist by existing one, all file must work separately (we shouldn't expect other stix file to be ingested first)
  • Enable the extended error log to get better error message when e2e service fails to start.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@aHenryJard aHenryJard added the filigran team use to identify PR from the Filigran team label Jul 5, 2024
@aHenryJard aHenryJard linked an issue Jul 5, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (3ac0509) to head (5ad993e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7612      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         567      567              
  Lines       69946    69946              
  Branches     5936     5935       -1     
==========================================
- Hits        47253    47252       -1     
- Misses      22693    22694       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard merged commit 7e2dc0c into master Jul 8, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/7611-e2e-data branch August 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update stix data for end to end tests
3 participants