Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] improve file indexing metrics performance (#7530) #7556

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jul 1, 2024

Proposed changes

  • use aggregation to count files by mime type

Related issues

performance issue not reproduced locally => need to test queries directly on DB (with platform team)

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jul 1, 2024
@SouadHadjiat SouadHadjiat linked an issue Jul 1, 2024 that may be closed by this pull request
@SouadHadjiat SouadHadjiat marked this pull request as ready for review July 1, 2024 15:56
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (335977c) to head (8e6b3bc).
Report is 1 commits behind head on master.

Files Patch % Lines
...l/src/modules/internal/document/document-domain.ts 20.00% 12 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/file.js 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7556      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         567      567              
  Lines       69903    69917      +14     
  Branches     5937     5938       +1     
==========================================
+ Hits        47225    47230       +5     
- Misses      22678    22687       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec
Copy link
Contributor

The files count is always set to 1 on my file indexing page
image

@SouadHadjiat SouadHadjiat merged commit d64eb35 into master Jul 3, 2024
5 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/7530 branch July 3, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File indexing page is too slow to be production grade ready
2 participants