-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Add OpenID Connect SSO support for Microsoft ADFS to get user claims from the id_token #7478
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7478 +/- ##
==========================================
- Coverage 66.19% 66.18% -0.02%
==========================================
Files 597 597
Lines 60387 60391 +4
Branches 6193 6192 -1
==========================================
- Hits 39974 39968 -6
- Misses 20413 20423 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0a0c699
to
ba7cc62
Compare
042ffe8
to
af64cc3
Compare
Spoke with @SarahBocognano and @marieflorescontact in Slack on whether or not test need to be added since the CodeCov report was complaining that the code I have added is not being tested, but it appears that most of the provider.js code does not have any related tests and was mentioned that it is likely acceptable to not add tests within this PR since there the provider.js tests likely would be added holistically at some future point in time. I have refactored the code slightly to ensure that the id_token is not decoded unless any of the userinfo attributes do not exist and then attempt to obtain them from the decoded id_token, so the code I have added should be bypassed entirely unless the userinfo data does not exist. |
f8359b7
to
558e6c1
Compare
Hi @animedbz16,
Thanks |
Yes, I will look to make those updates to support a new config / environment variable and default this to false since this would require the user to explicitly configure this true to enable this behavior and if not continue to function as it does today. |
ddecd42
to
f136ac9
Compare
@richard-julien I refactored this to add a Let me know if there is anything else that would need to be done here. I assume another PR would likely need to be created to document this new configuration option once it is approved / merged. |
…ibutes from the id token
#7477
Proposed changes
Related issues
Checklist
Further comments