-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] add askAnalysis mutation to request file or fields analysis (#6803) #7192
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7192 +/- ##
==========================================
- Coverage 67.67% 67.59% -0.09%
==========================================
Files 561 561
Lines 69059 69190 +131
Branches 5879 5880 +1
==========================================
+ Hits 46735 46768 +33
- Misses 22324 22422 +98 ☔ View full report in Codecov by Sentry. |
b0f6ee0
to
bfa4cd9
Compare
921d4f6
to
dd63210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locally tested ok 👌
user, | ||
event_access: 'extended', | ||
event_type: 'command', | ||
event_scope: 'analyze', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new scope not handled in ActivityListener
const message = `asks for \`${entity_name}\` enrichment with connector \`${connector_name}\``; | ||
await activityLogger(action, message); | ||
} | ||
if (action.event_scope === 'enrich') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there was an issue here, if (action.event_scope === 'enrich') {
block is present 3 times, I guess we only need if (action.event_scope === 'analyze') {
block
17a379b
to
41f695a
Compare
Proposed changes
see related client, connector and docker PR
OpenCTI-Platform/client-python#666
OpenCTI-Platform/connectors#2190
OpenCTI-Platform/docker#294
Related issues
Checklist
Further comments