-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix Add height / weight do not work (#7118) #7165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7165 +/- ##
==========================================
- Coverage 67.54% 67.54% -0.01%
==========================================
Files 561 561
Lines 68727 68727
Branches 5835 5835
==========================================
- Hits 46425 46420 -5
- Misses 22302 22307 +5 ☔ View full report in Codecov by Sentry. |
What is the meaning for the (') unit (simple curiosity)? (I know 'lb' for weight but I don't know (') ) @SarahBocognano : this is how we define height in America everytime you'll see a height, I will be like: 5'7" (172cm) |
7e5f6d8
to
e810af4
Compare
e810af4
to
5e93376
Compare
e5c4838
to
e677fc3
Compare
When adding a height, after delete the previous date, this date is reinitialized automatically. @SarahBocognano : Yes I did that on purpose to avoid any error for the user and to show that this field is indeed mandatory and has no sense of use without the date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can create TAI with null measure or date for height and weight, I suppose not intended but at least when setting real values it works well
Proposed changes
Related issues
Checklist
Further comments