[Frontend/Backend] split cpapabilites Data Sharing & Ingestion into 3 + manage CSV + Bypass ref + Connector Api (#7428)

[frapuks]

Proposed changes

MAJOR :

• Create capabilities : "Access Ingestion", "Manage Ingestion"
• Update "Access data sharing & ingestion" into "Access data sharing"
• Update "Manage data sharing & ingestion" into "Manage data sharing"
• Update acces rights for ingestion pages and queries
• Replace "Manage CSV mappers" without parent capability

MINOR :

• Add translation for capabilities and manage uppercase
• Update "Bypass ref" : name, order and description
• Replace "Connector Api usage" after (not under) "Access connector"

Related issues

• Split capabilities to create labels / marking etc & update other capabilities to provide more clarity in RBAC #5550 Chuck 1
• close Split "data sharing and ingestion" capability into 3 #7428

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case (coverage and e2e)
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

Capabilities properties :

• description : string displayed in the frontend
• attribute order : determines the display order
• name : string built from parent capabilities and used in the platform to check access rights

Access Ingestion

• Access ingestions pages

Manage Ingestion

• Access ingestions pages
• CRUD

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (f97dbe0) to head (113b78c).
Report is 2 commits behind head on master.

Files	Patch %	Lines
...pencti-graphql/src/database/data-initialization.js	0.00%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7149      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.03%     
==========================================
  Files         561      561              
  Lines       69236    69255      +19     
  Branches     5867     5908      +41     
==========================================
+ Hits        46705    46741      +36     
+ Misses      22531    22514      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SarahBocognano]

Question: When I check the capability to "access" data sharing but not the "manage" data sharing box I cannot access to the data sharing menu at all. Is it the attended behavior ?

[frapuks]

Question: When I check the capability to "access" data sharing but not the "manage" data sharing box I cannot access to the data sharing menu at all. Is it the attended behavior ?

It's true, I naively thought that the existing state of the ‘data sharing’ section was correct. => fixed

[frapuks]

It's ready for a 2nd round of review

[SarahBocognano]

Retested ✅

[aHenryJard]

Tested locally, I cannot import a csv file without having settings capa, but not sure if it's related to this PR or not.

[SouadHadjiat]

please rename migration to update its timestamp before merge

[SouadHadjiat]

When having "access ingestion" capabilility (without manage ingestion), I can see the edit buttons of CSV feeds and if I try to edit it redirects me to login page:

I also have the button + to create a new CSV ingestion but it also redirects me to login page. I guess it's because I'm trying to load CSV mappers list and it's protected by INGESTION_SETCSVMAPPERS capability

For RSS feeds and Taxii feeds, I only see the list, without any action

=> DONE

[SouadHadjiat]

make sure before merging that the migration timestamp is up to date with master