Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Clean up entity-type filter in Correlation Graphs #7145

Merged

Conversation

ckane
Copy link
Contributor

@ckane ckane commented May 28, 2024

Proposed changes

  • Remove the relational options from the entity-types filter on Correlation Graphs
  • Remove the Report and Reported in from the entity-types filter in Analysis Reports Correlation Graphs

This is done because the purpose of the Correlation Graph view for a particular entity is to chart relationships to other instances of the same entity type, in order to discover/explore relationships visually. Because of this, an Analysis Report should never allow the Report entity type to be filtered out.

image

Additionally, the entity type filters were also presenting options for relationship types (based-on, reported-in, etc...) as filterable entity types. These did not appear to change the visualization, and also do not make sense as options in this view. These have been filtered out by looking for cases where the n.node.entity_type begins with a lowercase letter.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@ckane ckane force-pushed the fix-correlation-chart-filter-types branch 2 times, most recently from 0081692 to 7cb40d5 Compare May 28, 2024 06:12
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (e383348) to head (faf3549).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7145      +/-   ##
==========================================
- Coverage   67.54%   67.53%   -0.02%     
==========================================
  Files         561      561              
  Lines       68754    68754              
  Branches     5837     5836       -1     
==========================================
- Hits        46443    46436       -7     
- Misses      22311    22318       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit self-requested a review May 28, 2024 07:27
@SouadHadjiat SouadHadjiat added the community use to identify PR from community label May 28, 2024
@ckane
Copy link
Contributor Author

ckane commented May 28, 2024

Here's a better before/after screenshot set:
image image

@Archidoit
Copy link
Member

@ckane I approved your PR, but we need you to sign your commits in order to be able to merge the PR... See https://docs.github.com/fr/authentication/managing-commit-signature-verification/about-commit-signature-verification for more infos

@ckane ckane force-pushed the fix-correlation-chart-filter-types branch 2 times, most recently from b05ba83 to 36c689f Compare June 3, 2024 22:16
@ckane
Copy link
Contributor Author

ckane commented Jun 3, 2024

Ok @Archidoit, should be ready - let me know if I did it correctly or not

@ckane ckane force-pushed the fix-correlation-chart-filter-types branch from 36c689f to b295544 Compare June 3, 2024 22:27
The "entity_*" options shouldn't show up as an option in the Correlation
Knowledge graphs. Additionally, an Analysis Report Correlation Graph
shouldn't allow the Report or Reported-in options in the entity-type
filter, either.
@ckane ckane force-pushed the fix-correlation-chart-filter-types branch from b295544 to faf3549 Compare June 3, 2024 22:28
@Archidoit
Copy link
Member

It's done correctly @ckane :) thanks

@Archidoit Archidoit merged commit de28ba1 into OpenCTI-Platform:master Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants