Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement route 'infra / knowledge / incident' (#6415) #6419

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Mar 22, 2024

Proposed changes

  • Remove 3 buttons that shouldn't exist
  • Create new route to display relashionship between Infrastructures and Incidents (types of relations : 'uses' / 'compromises')

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

infra - incident

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Mar 22, 2024
@frapuks frapuks self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (0c8c045) to head (d689842).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6419   +/-   ##
=======================================
  Coverage   67.30%   67.31%           
=======================================
  Files         541      541           
  Lines       65192    65192           
  Branches     5414     5416    +2     
=======================================
+ Hits        43879    43884    +5     
+ Misses      21313    21308    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks changed the title fix empty pages implement route 'infra / knowledge / incident' (#6415) Mar 22, 2024
@frapuks frapuks merged commit 12540ed into master Mar 22, 2024
8 checks passed
@frapuks frapuks deleted the issue/6415 branch March 22, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty knowledge pages
2 participants