Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] remove duplicate header (#6401) #6414

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[frontend] remove duplicate header (#6401) #6414

merged 1 commit into from
Mar 22, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Mar 22, 2024

Proposed changes

Entities / Events / Knowledge :

  • Remove duplicate header

Techniques / Courses of action / select one / select one relationship :

  • Remove duplicate header
  • Remove padding right
  • Focus Overview tab

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • Please challenge the choice of focus Overview tab
  • Demo :
    knowledge

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Mar 22, 2024
@frapuks frapuks self-assigned this Mar 22, 2024
@frapuks frapuks linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (0330878) to head (a905598).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6414      +/-   ##
==========================================
- Coverage   67.31%   67.31%   -0.01%     
==========================================
  Files         541      541              
  Lines       65192    65192              
  Branches     5416     5416              
==========================================
- Hits        43884    43883       -1     
- Misses      21308    21309       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks merged commit 0c8c045 into master Mar 22, 2024
8 checks passed
@frapuks frapuks deleted the issue/6401 branch March 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate header
2 participants