[backend] Update errors that are not retryable #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6366 +/- ##
=======================================
Coverage 66.74% 66.75%
=======================================
Files 541 541
Lines 64553 64551 -2
Branches 5306 5306
=======================================
Hits 43088 43088
+ Misses 21465 21463 -2 ☔ View full report in Codecov by Sentry. |
| const isRetryableCall = isNotEmptyField(origin?.call_retry_number) && 
There was a problem hiding this comment.
DuplicateEntryError seems never used
Kedae
force-pushed
the
oob/fix_error_handling
branch
from
503350d
to
ed573ff
Compare
labo-flg
approved these changes
Mar 20, 2024
helene-nguyen
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the actual error to be logged and not bypassed because they are not retryable