[frontend] fix filters adding for TimeLine views, Alert Live, and label icon (#6348) #6349
Conversation
Archidoit
added
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6349 +/- ##
==========================================
- Coverage 66.74% 66.73% -0.01%
==========================================
Files 541 541
Lines 64530 64530
Branches 5306 5306
==========================================
- Hits 43068 43067 -1
- Misses 21462 21463 +1 ☔ View full report in Codecov by Sentry. |
| <Loader | ||
| variant={LoaderVariant.inElement} | ||
| withTopMargin={true} | ||
| <UserContext.Consumer> |
There was a problem hiding this comment.
ouch. But probably "a bit" more work if we want to refactor this component and use hooks :)
There was a problem hiding this comment.
yes it's far better to use hook... but need refacto ^^'
| this, | ||
| )} | ||
| handleToggleModeOnlyActive={this.handleToggleModeOnlyActive.bind( | ||
| timeLineFilters={timeLineFilters} | ||
| handleAddTimeLineFilter={this.handleAddTimeLineFilter.bind( |
There was a problem hiding this comment.
Just from reading the code, it looks like handleAddTimeLineFilter has a different signature now, but we pass it as a parameter to ContentKnowledgeTimeLineBar which then uses it directly to pass it to Filters component (handleAddFilter={handleAddTimeLineFilter}) but handleAddFilter type doesn't have the same signature anymore.
PR content: