Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix Data > Ingestion and Processing menus access (#6312) (#6328) (#6329) #6340

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Mar 13, 2024

Proposed changes

  • Fix unauthorized access to Data > Processing when "manage credentials" capability is missing but csv mapper capability is present
  • Fix ingestion menu access : should be accessible if one of "settings" or "modules" capabilities is present.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 13, 2024
@SouadHadjiat SouadHadjiat linked an issue Mar 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (dea383c) to head (8e3bd62).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6340   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files         541      541           
  Lines       64530    64530           
  Branches     5307     5307           
=======================================
  Hits        43069    43069           
  Misses      21461    21461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat changed the title [frontend] Fix unauthorized access to Data > Processing (#6312) [frontend] Fix Data > Ingestion and Processing menus access (#6312) (#6328) (#6329) Mar 14, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review March 14, 2024 10:29
@labo-flg
Copy link
Member

#6329 seems unresolved

image

@labo-flg
Copy link
Member

Ok it's actually solved with last cmomit, my bad.

@SouadHadjiat SouadHadjiat merged commit 7b2a771 into master Mar 14, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6312 branch March 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unauthorized access to Data > Processing
2 participants