-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Add samples attribute to Malware in API #6337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6337 +/- ##
=======================================
Coverage 66.74% 66.75%
=======================================
Files 541 541
Lines 64553 64555 +2
Branches 5306 5307 +1
=======================================
+ Hits 43088 43093 +5
+ Misses 21465 21462 -3 ☔ View full report in Codecov by Sentry. |
1bf6955
to
36f73f7
Compare
84a7fec
to
5dff342
Compare
@@ -5596,6 +5597,7 @@ input MalwareAddInput { | |||
objectLabel: [String] | |||
externalReferences: [String] | |||
killChainPhases: [String] | |||
samples: [String] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be changes in the generated file graphql.ts (when I started the backend I saw these changes locally)
36f73f7
to
726c36f
Compare
3862ef6
to
7448286
Compare
Proposed changes
I added "samples" to the api model of malware, so that we can properly import sample refs when importing a malware stix bundle
See also the python client PR OpenCTI-Platform/client-python#584
Related issues
Checklist