Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix createdBy validation on SDO edit (#6291) #6332

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Mar 13, 2024

Proposed changes

  • Fix error "Cannot read properties of undefined (reading '0')" when editing an entity's author

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 13, 2024
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (1a0ae19) to head (9113b2e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6332   +/-   ##
=======================================
  Coverage   66.73%   66.74%           
=======================================
  Files         541      541           
  Lines       64529    64529           
  Branches     5306     5306           
=======================================
+ Hits        43066    43068    +2     
+ Misses      21463    21461    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat merged commit 674496b into master Mar 13, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6291-fix branch March 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants