Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix instance triggers subscription (#6313) #6317

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Mar 12, 2024

Proposed changes

  • Filter instance triggers to handle only triggers of current user
  • TODO : add e2e test

Related issues

The issue happens with admin users (set access capa). Admin users can query all instance triggers (used to display the subscribers details) but they should only update theirs.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 12, 2024
@SouadHadjiat SouadHadjiat linked an issue Mar 12, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.71%. Comparing base (beaac8f) to head (1baa8f5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6317   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files         541      541           
  Lines       64501    64501           
  Branches     5288     5289    +1     
=======================================
+ Hits        43033    43035    +2     
+ Misses      21468    21466    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat marked this pull request as ready for review March 12, 2024 17:00
@SouadHadjiat
Copy link
Member Author

Opening the PR with the fix, but without the e2e test since it takes some time to write, in case we need to merge this PR quickly.

@SarahBocognano
Copy link
Member

Tested ✅

@SouadHadjiat SouadHadjiat merged commit a131011 into master Mar 13, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6313 branch March 13, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical bug in subscribers / instance trigger
2 participants