-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] fix history filters in activity tab (#6293) #6305
Conversation
context_data.id is also present in StixCoreObjectLatestHistory.ts, StixCoreObjectRelationshipHistory.ts and StixCoreObjectRelationshipLatestHistory.ts |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6305 +/- ##
=======================================
Coverage 66.73% 66.74%
=======================================
Files 541 541
Lines 64529 64530 +1
Branches 5306 5307 +1
=======================================
+ Hits 43066 43069 +3
+ Misses 21463 21461 -2 ☔ View full report in Codecov by Sentry. |
Tested OK, but as Cathia said there might be other places to update with the same kind of filter. |
in these cases I don't think we should filter on |
If these screens refer to the history of the relationship object itself, then context_data.id might be the right filter key, yes. |
@marieflorescontact what's strange is that I don't see 'id' in the mappings of the 'context_data' attribute (see internalObject-registrationAttributes.ts) |
FYI in elastic, it's present. it's the entity id on which the operation has been logged. |
I wil add some test before merging |
171fe52
to
fe24e6b
Compare
fe24e6b
to
e1d9adf
Compare
I need more time to implement tests |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...