Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix history filters in activity tab (#6293) #6305

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Mar 11, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact self-assigned this Mar 11, 2024
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Mar 11, 2024
@Archidoit
Copy link
Member

context_data.id is also present in StixCoreObjectLatestHistory.ts, StixCoreObjectRelationshipHistory.ts and StixCoreObjectRelationshipLatestHistory.ts

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (1a0ae19) to head (9fe02ec).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6305   +/-   ##
=======================================
  Coverage   66.73%   66.74%           
=======================================
  Files         541      541           
  Lines       64529    64530    +1     
  Branches     5306     5307    +1     
=======================================
+ Hits        43066    43069    +3     
+ Misses      21463    21461    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg
Copy link
Member

Tested OK, but as Cathia said there might be other places to update with the same kind of filter.

@marieflorescontact
Copy link
Member Author

context_data.id is also present in StixCoreObjectLatestHistory.ts, StixCoreObjectRelationshipHistory.ts and StixCoreObjectRelationshipLatestHistory.ts

in these cases I don't think we should filter on context_data.from_id and context_data.to_id. it seems to work well as it is now. @labo-flg @Archidoit

@labo-flg
Copy link
Member

If these screens refer to the history of the relationship object itself, then context_data.id might be the right filter key, yes.

@Archidoit
Copy link
Member

@marieflorescontact what's strange is that I don't see 'id' in the mappings of the 'context_data' attribute (see internalObject-registrationAttributes.ts)

@labo-flg
Copy link
Member

FYI in elastic, it's present. it's the entity id on which the operation has been logged.

@marieflorescontact
Copy link
Member Author

I wil add some test before merging

@marieflorescontact
Copy link
Member Author

I need more time to implement tests

@marieflorescontact marieflorescontact merged commit dea383c into master Mar 13, 2024
8 checks passed
@marieflorescontact marieflorescontact deleted the issue/6293 branch March 13, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In activity tab, the relation history is not working anymore
3 participants