Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] dont disable when value > limit (#6294) #6299

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Mar 11, 2024

Proposed changes

  • Update condition to manage diable : use initial value.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Mar 11, 2024
@frapuks frapuks self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.71%. Comparing base (beaac8f) to head (62c5442).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6299   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files         541      541           
  Lines       64501    64501           
  Branches     5288     5288           
=======================================
  Hits        43033    43033           
  Misses      21468    21468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec self-requested a review March 11, 2024 11:08
Copy link
Contributor

@JeremyCloarec JeremyCloarec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the behavior of the field when a user without enough confidence to edit an object opens the edit form: the field is not disabled when we want it to be

@frapuks frapuks marked this pull request as draft March 11, 2024 13:12
@frapuks frapuks marked this pull request as ready for review March 12, 2024 13:07
@frapuks frapuks merged commit 698b5a3 into master Mar 12, 2024
8 checks passed
@frapuks frapuks deleted the issue/6294 branch March 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants