Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] horizontal bars representing labels should not be clickable #6289

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Archidoit
Copy link
Member

issue: #6264

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Mar 7, 2024
@Archidoit Archidoit self-assigned this Mar 7, 2024
@Archidoit Archidoit marked this pull request as draft March 7, 2024 19:59
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.71%. Comparing base (607b674) to head (e9cf396).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6289   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files         541      541           
  Lines       64501    64501           
  Branches     5288     5289    +1     
=======================================
  Hits        43035    43035           
  Misses      21466    21466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit marked this pull request as ready for review March 11, 2024 14:33
JeremyCloarec

This comment was marked as resolved.

@Archidoit
Copy link
Member Author

Ok for labels not being clickable anymore. The change to the cursor isn't working properly though: we no longer have a pointer cursor when hovering clickable charts in dashboards (in the Most active threats widget for exemple). I think we can keep the way cursors were displayed before, and only keep the changes to the xAsixLabelClick and click events

fixed :)

@Archidoit Archidoit merged commit beaac8f into master Mar 12, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/6264 branch March 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants