Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Improve Simplified Chinese translations #6277

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

satan1a
Copy link
Contributor

@satan1a satan1a commented Mar 5, 2024

Proposed changes

This PR aims to add and optimize Simplified Chinese translations for the OpenCTI open-source threat intelligence platform and to fix some translation issues in the historical zh.json. During the translation and revision process, I focused particularly on several important aspects: consistency, accuracy, cultural appropriateness, and correction of historical translation issues. I look forward to feedback from project maintainers and the community and am willing to further adjust and perfect my translations to ensure they meet user needs and expectations to the greatest extent possible.

Consistency:

  • I thoroughly reviewed the existing Chinese translation versions to ensure my contributions were highly consistent with the project's style and terminology. Especially in the use of professional terminology in the field of threat intelligence, I followed industry standards and terminology already adopted within the project.
    • Example: For instance, translating “vulnerability” uniformly as “漏洞” instead of “脆弱性” ensured consistent use of terminology. In contrast, “脆弱性” might convey the existence of potential risks or weaknesses, but it is more broadly defined and may not be as precise as “漏洞” in the field of cyber security.

Accuracy:

  • My translation work is based on thorough research to ensure the accuracy of each term and expression. I referred to multiple authoritative threat intelligence materials and standards to ensure that the translations are both accurate and reflect the latest industry knowledge. This also included consulting related Chinese academic papers on threat intelligence technologies.
    • Example: Regarding Chinese threat intelligence technologies, I referred to relevant Chinese papers, including: “LI Jian-hua. Overview of the technologies of threat intelligence sensing, sharing and analysis in cyber space. Chinese Journal of Network and Information Security[J], 2016, 2(2): 16-29 doi:10.11959/j.issn.2096-109x.2016.00028”

Cultural Appropriateness:

  • Considering that Simplified Chinese users of OpenCTI might come from different backgrounds, I made localized adjustments to certain expressions to better align with the reading habits and cultural characteristics of Simplified Chinese users.
    • Example: Since there is no corresponding Chinese term for “Markdown” that Simplified Chinese users are accustomed to, they still habitually refer to it as Markdown. Therefore, I translated “Markdown files” as “Markdown文件”. In the context of Simplified Chinese, especially in fields related to internet technology, many English terms are directly borrowed without being localized, or even if there is a localized translation, the original English term is widely retained due to its broad international use. "Markdown" is one such example. This approach not only facilitates understanding by Chinese readers but also retains consistency with international usage.
    • Example: Abstracts of commentary content are generally referred to as “摘要” instead of “抽象”. This translation more accurately conveys the meaning of “abstract” in these texts, which is to distill the main content of the document into a concise presentation, rather than literally translating it as “抽象”, which is more often used to describe the abstraction of thought or artwork in Chinese.

Correction of Historical Translation Issues:

  • In reviewing the zh.json file, I identified and corrected some typos, inconsistencies in the translation of specific terms in context, and potentially ambiguous issues. These corrections further improved the quality and consistency of the translation, ensuring that Chinese users receive more accurate and clear information.

    • Example: In historical versions, the term “attacker” was inconsistently translated in different contexts, sometimes as “[to be filled]”. I unified the use of relevant terminology to eliminate ambiguity.
    • Example: In historical versions, several Japanese terms were used in the zh.json file, such as “インデックスされたファイル” and “ポーズ”. I corrected these translations.

Additionally, seeing the recent release of version 6.X, I am very happy to see such an active and useful open-source threat intelligence project. I wish your team all the best and thank you for your efforts.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (b483357) to head (b5c9b2d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6277      +/-   ##
==========================================
- Coverage   66.64%   66.63%   -0.02%     
==========================================
  Files         541      541              
  Lines       64458    64458              
  Branches     5258     5256       -2     
==========================================
- Hits        42957    42950       -7     
- Misses      21501    21508       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine
Copy link
Member

Thanks a lot for this great contribution!

@SamuelHassine SamuelHassine merged commit d9e8fef into OpenCTI-Platform:master Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants