-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix cannot add TTP directly from matrix (#6112) #6272
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6272 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 541 541
Lines 64420 64420
Branches 5257 5257
=======================================
Hits 42957 42957
Misses 21463 21463 ☔ View full report in Codecov by Sentry. |
b05fc8e
to
9887c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial issue is fix.
Just, is it normal that we can add multiple times the same relation between an Intrusion and a Technique? That's not directly related to the fix but now that the Add button works we face this scenario
@SarahBocognano It actually doesn't add multiple times the same relation, but yes maybe we can "disable" the add button if the relation already exist
9887c01
to
5a5c876
Compare
655453f
to
d793a45
Compare
Update: After a call with @nino-filigran , we will keep the "Add" button. Eveything is okay for product side, we can merge this issue like that |
Related issues