Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix filter key 'objects', usable in any sro and sco (#6188) #6195

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Mar 1, 2024

closes #6188

The filter key 'objects' is not only used as a regular attribute-filter for containers, but also for any SCO/SRO that might be contained in a container.

solution => We declare it in the filterKeysSchema for any SRO/SCO

@labo-flg labo-flg self-assigned this Mar 1, 2024
@labo-flg labo-flg requested a review from jpkha March 1, 2024 08:59
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (583dfbd) to head (110f6f3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6195   +/-   ##
=======================================
  Coverage   66.67%   66.68%           
=======================================
  Files         540      540           
  Lines       64351    64363   +12     
  Branches     5251     5252    +1     
=======================================
+ Hits        42909    42923   +14     
+ Misses      21442    21440    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Mar 1, 2024
@labo-flg labo-flg merged commit a678e19 into master Mar 1, 2024
8 checks passed
@labo-flg labo-flg deleted the issue/6188 branch March 1, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select ALL now affect to all Data instead of a Page
3 participants