Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix dashboard import minimal version check (#6181) #6184

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Feb 29, 2024

Proposed changes

  • use semver lib to compare version
  • add tests

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 29, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review February 29, 2024 16:10
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (3fd83cd) to head (ab6c4d5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6184   +/-   ##
=======================================
  Coverage   66.67%   66.68%           
=======================================
  Files         540      541    +1     
  Lines       64349    64349           
  Branches     5250     5248    -2     
=======================================
+ Hits        42907    42912    +5     
+ Misses      21442    21437    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat merged commit 04269dc into master Mar 1, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6181 branch March 1, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard exported on 6.0 can't be imported again (invalid version error)
2 participants