Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix breadcrumbs (#6164) #6168

Merged
merged 2 commits into from
Feb 29, 2024
Merged

[frontend] fix breadcrumbs (#6164) #6168

merged 2 commits into from
Feb 29, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 29, 2024

Proposed changes

  • Update breadcrumbs in Cases / Feedbacks with right value
  • Add breadcrumbs in Settings / Customization / Decay Rules

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • I used the same string as in the menu so that the translation would work for sure.

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 29, 2024
@frapuks frapuks self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (f0c79df) to head (277f47c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6168   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files         540      540           
  Lines       64349    64349           
  Branches     5251     5252    +1     
=======================================
+ Hits        42912    42914    +2     
+ Misses      21437    21435    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae linked an issue Feb 29, 2024 that may be closed by this pull request
@frapuks frapuks merged commit 3fd83cd into master Feb 29, 2024
8 checks passed
@frapuks frapuks deleted the issue/6164 branch February 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs error on Case
2 participants