-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] Public dashboard chunk 2 (#4903) #5951
Conversation
691d549
to
1d486ca
Compare
3888dcf
to
af4afaf
Compare
af4afaf
to
2ded71f
Compare
950a3a8
to
0e6c63f
Compare
0e6c63f
to
d62d06c
Compare
cdc32a6
to
6368e31
Compare
8b53dfa
to
ed7c651
Compare
5884121
to
cde7fe5
Compare
17f1ce2
to
12be3bd
Compare
Could you move the widget definition in another file in the tests, please ? |
f0606a2
to
560de78
Compare
84a7fec
to
5dff342
Compare
040e176
to
0551de1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pair reviewed, comments addressed.
Tested on several dashboards.
Last remarks is about the date on the line graph: the date are technical in private dashboard, but seems to be the real creation date once public.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5951 +/- ##
==========================================
+ Coverage 66.97% 67.31% +0.34%
==========================================
Files 541 541
Lines 64557 64992 +435
Branches 5313 5393 +80
==========================================
+ Hits 43234 43748 +514
+ Misses 21323 21244 -79 ☔ View full report in Codecov by Sentry. |
db863fa
to
7e5cafd
Compare
Co-authored-by: Laurent Bonnet <146674147+labo-flg@users.noreply.github.com>
7e5cafd
to
dfe5929
Compare
dfe5929
to
0c8055a
Compare
0c8055a
to
7fecdd1
Compare
Proposed changes
Context recap: possibility to publish a version of a dashboard that is visible by every having the url. No need to be connected to OpenCTI. In the previous chunk (merged) we defined the process to create public dashboard and implemented one widget to feature the scenario. The objective of this PR is to generalize to all the widgets we can have in a dashboard.
Related issues
Checklist
Further comments
80% of the lines are refactoring and new widgets on frontend side. And there is a lot, it's not possible to read all the changes so we invite to focus more on the backend code and manual testing for the widgets.
How to test?