[backend] Works tracking fail to complete at "update processed time" (#5762) #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labo-flg
approved these changes
Jan 31, 2024
labo-flg
reviewed
Jan 31, 2024
| @@ -197,11 +197,6 @@ export const createWork = async (context, user, connector, friendlyName, sourceI | |||
| return loadWorkById(context, user, workId); | |||
| }; | |||
|
|
|||
| const isWorkCompleted = async (workId) => { | |||
| const { import_processed_number: pn, import_expected_number: en } = await redisGetWork(workId); | |||
| return { isComplete: parseInt(pn, 10) === parseInt(en, 10), total: pn }; | |||
There was a problem hiding this comment.
you would return also 'expected' now that was not returned before, no issue ?
There was a problem hiding this comment.
Expected is used by the caller of redisUpdateWorkFigures and not directly by the caller of isWorkCompleted.
I dont think its a problem.
lndrtrbn
approved these changes
Jan 31, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5763 +/- ##
=======================================
Coverage 64.71% 64.72%
=======================================
Files 516 516
Lines 60893 60890 -3
Branches 4856 4857 +1
=======================================
+ Hits 39409 39410 +1
+ Misses 21484 21480 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5762