Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] remove unecessary console.log in domino patch (#5679) #5746

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jan 30, 2024

Proposed changes

  • Remove console.log in domino patch

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aHenryJard aHenryJard added the filigran team use to identify PR from the Filigran team label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (605eb54) 66.14% compared to head (57214cc) 66.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   66.14%   66.14%   -0.01%     
==========================================
  Files         513      513              
  Lines       60805    60805              
  Branches     4447     4447              
==========================================
- Hits        40220    40219       -1     
- Misses      20585    20586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard marked this pull request as ready for review January 30, 2024 10:59
@SamuelHassine SamuelHassine merged commit c684db0 into master Jan 30, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5679 branch January 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Useless console.log in domino patch need to be remove for log consistency
2 participants