Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Improve UX filter for 'no-label' and fix date value #5685

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

jpkha
Copy link
Member

@jpkha jpkha commented Jan 25, 2024

Proposed changes

  • Improve UX filter for 'no-label'
  • Fix date value which is not showing once selected in popover
  • Refactor filter to group all the logic in one utils file.

@jpkha jpkha requested a review from Archidoit January 25, 2024 12:37
@jpkha jpkha added filters & search Linked to search results and filtering engine filigran team use to identify PR from the Filigran team labels Jan 25, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3df58b) 66.11% compared to head (c58ef3c) 66.11%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5685   +/-   ##
=======================================
  Coverage   66.11%   66.11%           
=======================================
  Files         513      513           
  Lines       60793    60793           
  Branches     4445     4444    -1     
=======================================
  Hits        40191    40191           
  Misses      20602    20602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Megafredo Megafredo self-requested a review January 26, 2024 15:32
@jpkha jpkha merged commit 34f2d50 into master Jan 26, 2024
8 checks passed
@jpkha jpkha deleted the issue/improve-filter branch January 26, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team filters & search Linked to search results and filtering engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants