-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters display in Report Timeline view (#5636) #5667
Conversation
5895f5b
to
0dfc2d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5667 +/- ##
==========================================
- Coverage 64.72% 64.71% -0.01%
==========================================
Files 516 516
Lines 60893 60893
Branches 4857 4855 -2
==========================================
- Hits 39414 39409 -5
- Misses 21479 21484 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @marieflorescontact, also can you maybe just move the 'close' button because I think it's kind of overlap |
It's a quick fix to display all the filters that were hidden before, only on this screen. The filter team is currently changing the display of each filter. |
@marieflorescontact @SarahBocognano I reviewed this issue with JP. This problem exists on all screens where we have filters. However, he thinks that the chevron is not necessary. Thank you for your feedback. |
b4250bf
to
b4d3416
Compare
@SarahBocognano @marieflorescontact I have implemented some changes, could you please provide a new review for these updates? |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...