-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] adding decay chart in indicator lifecycle overview (#2859) #5639
Conversation
dfed9a6
to
50aa28f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5639 +/- ##
==========================================
+ Coverage 66.15% 66.43% +0.28%
==========================================
Files 513 514 +1
Lines 60788 60869 +81
Branches 4447 4614 +167
==========================================
+ Hits 40214 40439 +225
+ Misses 20574 20430 -144 ☔ View full report in Codecov by Sentry. |
opencti-platform/opencti-graphql/tests/01-unit/domain/decay-test.ts
Outdated
Show resolved
Hide resolved
e21f6cb
to
7dc03e4
Compare
7dc03e4
to
0530e3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal but on the horizontal line we can see the creation date but not the revoke date, maybe it is done on purpose ?
otherwise it works fine 👌
opencti-platform/opencti-graphql/src/modules/indicator/decay-chart-domain.ts
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-graphql/src/modules/indicator/decay-chart-domain.ts
Outdated
Show resolved
Hide resolved
f49be1c
to
a05d1fb
Compare
…hart-domain.ts Co-authored-by: Marie Flores <73853856+marieflorescontact@users.noreply.github.com>
a05d1fb
to
3de0de7
Compare
opencti-platform/opencti-front/src/private/components/observations/indicators/DecayDialog.tsx
Outdated
Show resolved
Hide resolved
…ions/indicators/DecayDialog.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review done, only one remark repeated at different part of the code. I'll test locally now
Proposed changes
Chunck 3 of decay topic: add visual graph in Indicator overview.
Dark mode:
Light mode:
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...