-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] add effective_confidence_level computed field to users (#4304) #5596
[backend] add effective_confidence_level computed field to users (#4304) #5596
Conversation
173cc19
to
6736184
Compare
32b5a01
to
00ac6e9
Compare
Co-authored-by: Laurent Bonnet <laurent.bonnet@filigran.io>
* only on groups + user * fix tests, include source
f89e83b
to
de7691a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## issue/4304-confidence-new-schema-def #5596 +/- ##
=======================================================================
Coverage ? 66.27%
=======================================================================
Files ? 508
Lines ? 59947
Branches ? 4382
=======================================================================
Hits ? 39728
Misses ? 20219
Partials ? 0 ☔ View full report in Codecov by Sentry. |
993282c
into
issue/4304-confidence-new-schema-def
[To merge in feature branch for #4304]
This PR brings the
effective_confidence_level
to users.It's a computed value (algo described in code comments) and not an attribute in the schema, that depends on user's confidence level and the confidence levels of his organizations and groups.
We also add
platform_critical_alerts
as part of settings, if any a dialog is shown to admins at login / any refresh of the app.It invite admin to do something about an issue in the app with clear CTA. Only one alert possible: null effective confidence level found in some groups.
Further comments
Backend code was split to allow for easy unit tests, added to
user-test.ts
.Note that adding
group_confidence_level
andorg_confidence_level
is not part of this PR, but the algorithm will work fine as this will be optional fields anyway.