Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] view user's confidence level (#4304) #5292

Closed

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Dec 22, 2023

Proposed changes

  • view the user's confidence levels and overrides in the User view

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@labo-flg
Copy link
Member Author

To be reviewed after #5283

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (issue/4304-confidence-level@219b5c3). Click here to learn what that means.

❗ Current head cd3fdab differs from pull request most recent head b081205. Consider uploading reports for the commit b081205 to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                       @@
##             issue/4304-confidence-level    #5292   +/-   ##
==============================================================
  Coverage                               ?   65.69%           
==============================================================
  Files                                  ?      475           
  Lines                                  ?    59314           
  Branches                               ?     4325           
==============================================================
  Hits                                   ?    38967           
  Misses                                 ?    20347           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Dec 27, 2023
* new attribute user_confidence_level with default value and overrides per entity
* default confidence is set from platform settings (default to 100)
* elastic mapping as nested, to query overrides properly
* migration script to add the mapping and update all users with default confidence
@labo-flg labo-flg force-pushed the issue/4304-confidence-level-2 branch from c3469e9 to cd3fdab Compare December 28, 2023 13:22
@labo-flg labo-flg marked this pull request as ready for review December 29, 2023 10:20
@lndrtrbn lndrtrbn self-requested a review January 2, 2024 09:18
@labo-flg labo-flg force-pushed the issue/4304-confidence-level-2 branch from e3172bd to b081205 Compare January 2, 2024 10:11
@labo-flg
Copy link
Member Author

labo-flg commented Jan 9, 2024

Closing this PR in favor of #5436

@labo-flg labo-flg closed this Jan 9, 2024
@SamuelHassine SamuelHassine deleted the issue/4304-confidence-level-2 branch January 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants