Skip to content

Conversation

@JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Oct 13, 2025

Proposed changes

  • add ability to filter connectors to handle in worker: this could enable deploying workers only used for draft, or other workers only used for tasks etc...

Linked to OpenCTI-Platform/client-python#991
Linked to OpenCTI-Platform/docs#362

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec marked this pull request as ready for review October 13, 2025 10:38
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 13, 2025
@JeremyCloarec JeremyCloarec added the multi-repository For contribution that requires PR in several repository label Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.61%. Comparing base (0935c82) to head (66debae).
⚠️ Report is 145 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12731      +/-   ##
==========================================
+ Coverage   66.57%   66.61%   +0.03%     
==========================================
  Files         752      752              
  Lines       79668    79668              
  Branches     8557     8563       +6     
==========================================
+ Hits        53039    53069      +30     
+ Misses      26629    26599      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyCloarec JeremyCloarec linked an issue Oct 15, 2025 that may be closed by this pull request
@xfournet xfournet self-requested a review October 15, 2025 13:36
config,
default="",
)
self.targeted_connector_types = get_config_variable(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could rather use a separate thread pool for internal queues in order to keep unspecialized workers

@JeremyCloarec JeremyCloarec added the do not merge Do not merge this PR until this tag will be removed label Oct 15, 2025
@JeremyCloarec JeremyCloarec deleted the oob/workerPriorization branch October 24, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Do not merge this PR until this tag will be removed filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to dedicate workers to specific queues

2 participants