Skip to content

Conversation

@JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jun 4, 2025

Proposed changes

  • fix stixEdit capa required
  • now use id for rule activation description

client PR OpenCTI-Platform/client-python#906

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jun 4, 2025

######## STIX OBJECT
stixEdit(id: ID!): StixEditMutations @auth(for: [SETTINGS])
stixEdit(id: ID!): StixEditMutations @auth(for: [KNOWLEDGE])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to be looked into: this could cause a problem when deleting internal objects (labels for exemple)... We might need to keep the SETTINGS capa

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 34.48276% with 19 lines in your changes missing coverage. Please review.

Project coverage is 64.92%. Comparing base (edacb1a) to head (b6f3db4).
Report is 3 commits behind head on release/current.

Files with missing lines Patch % Lines
...pencti-platform/opencti-graphql/src/domain/stix.js 45.00% 11 Missing ⚠️
...latform/opencti-graphql/src/manager/taskManager.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/current   #11198      +/-   ##
===================================================
+ Coverage            64.89%   64.92%   +0.02%     
===================================================
  Files                  716      716              
  Lines                70523    70521       -2     
  Branches              7670     7676       +6     
===================================================
+ Hits                 45769    45788      +19     
+ Misses               24754    24733      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyCloarec JeremyCloarec added the multi-repository For contribution that requires PR in several repository label Jun 4, 2025
@JeremyCloarec JeremyCloarec marked this pull request as ready for review June 5, 2025 13:38
######## STIX OBJECT
type StixEditMutations {
delete(forceDelete: Boolean): ID
delete(forceDelete: Boolean): ID @auth(for: [SETTINGS])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need settings ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this delete API can be used to delete meta objects (like labels, kill chain phases etc...) which require SETTINGS capa

@JeremyCloarec JeremyCloarec removed the multi-repository For contribution that requires PR in several repository label Jun 11, 2025
@JeremyCloarec JeremyCloarec merged commit 4ba163c into release/current Jun 11, 2025
4 of 5 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/10274fixes branch June 11, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants