-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[backend/frontend] background tasks to worker fixes (#10274) #11198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| ######## STIX OBJECT | ||
| stixEdit(id: ID!): StixEditMutations @auth(for: [SETTINGS]) | ||
| stixEdit(id: ID!): StixEditMutations @auth(for: [KNOWLEDGE]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to be looked into: this could cause a problem when deleting internal objects (labels for exemple)... We might need to keep the SETTINGS capa
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #11198 +/- ##
===================================================
+ Coverage 64.89% 64.92% +0.02%
===================================================
Files 716 716
Lines 70523 70521 -2
Branches 7670 7676 +6
===================================================
+ Hits 45769 45788 +19
+ Misses 24754 24733 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ######## STIX OBJECT | ||
| type StixEditMutations { | ||
| delete(forceDelete: Boolean): ID | ||
| delete(forceDelete: Boolean): ID @auth(for: [SETTINGS]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need settings ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this delete API can be used to delete meta objects (like labels, kill chain phases etc...) which require SETTINGS capa
e80f34b to
dc729ce
Compare
dc729ce to
98bdd04
Compare
a71cdbb to
b6f3db4
Compare
Proposed changes
client PR OpenCTI-Platform/client-python#906
Related issues
Checklist
Further comments