Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error log at initialization + minio only numbers access/pass #995

Closed
richard-julien opened this issue Jan 13, 2021 · 1 comment
Closed
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@richard-julien
Copy link
Member

Description

With a specific minio env files with only numbers for access/secret, the platform fail to start with an empty error in the log.

Steps to create the smallest reproducible scenario:

  1. Checkout docker compose file
  2. Config env files with minio access/secret to only numbers
  3. Start the stack

Expected Output

Platform starting without errors

Actual Output

$ node --max_old_space_size=8192 build/index.js
{"level":"info","message":"[OPENCTI] Starting platform","timestamp":"2021-01-13T03:14:40.246Z"}
{"level":"info","message":"[CHECK] ElasticSearch is alive","timestamp":"2021-01-13T03:14:40.275Z"}
{"error":{},"level":"error","message":"[OPENCTI] Platform initialization fail","timestamp":"2021-01-13T03:14:40.278Z"}

Additional information

Will also improve the error log. The error should be reported like this.
{"error":{"name":"UnknownError","data":{"message":"accessKey should be of type "string"","_stack":"TypeError: accessKey should be of type "string"\n .... }}

@richard-julien richard-julien added the feature use for describing a new feature to develop label Jan 13, 2021
@richard-julien richard-julien added this to the Release 4.1.0 milestone Jan 13, 2021
@richard-julien
Copy link
Member Author

#994

@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

2 participants