Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RST Report Hub] Add missing generate id #3291

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[RST Report Hub] Add missing generate id #3291

merged 2 commits into from
Jan 16, 2025

Conversation

helene-nguyen
Copy link
Member

Proposed changes

  • Add missing generate id

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Jan 16, 2025
@helene-nguyen helene-nguyen self-assigned this Jan 16, 2025
@helene-nguyen helene-nguyen linked an issue Jan 16, 2025 that may be closed by this pull request
[RST Report Hub] Missing generate id #3290
Closed
Megafredo
Megafredo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job ;), it's ok for me !

@helene-nguyen helene-nguyen merged commit 2f2f4b2 into master Jan 16, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the bug/3290 branch January 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RST Report Hub] Missing generate id
2 participants
@helene-nguyen @Megafredo