[ExportReportPdf] list params fixed (#9082) #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinBouzinFiligran
added
the
filigran team
lndrtrbn
reviewed
Dec 2, 2024
| @@ -193,13 +193,19 @@ def _process_list( | |||
|
|
|||
| if entities_list is not None: | |||
| list_marking = None | |||
| if file_markings: | |||
| list_marking = file_markings[-1]["definition"] | |||
| if len(file_markings) != 0: | |||
There was a problem hiding this comment.
Are we sure file_markings is always a defined array ?
There was a problem hiding this comment.
Good question !
From the client, we send an array
And I tried from the graphql playground, if I send null or undefined ( or anything else that isn't an array ) it throws me an error
|
Tested👌 |
CelineSebe
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
It crashed when we tried to export a selection of entities with file_markings.
Then another case was fixed: it would also crash when list_params was empty.
ask Nino for more infos if needed