-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASHPOINT] Deprecate malware and APT mport options #2874
Conversation
@romain-filigran @Jipegien @SamuelHassine it may be a breaking change as we doesn't import malware and APT anymore, what do you think? |
I'm ok with this, this is a native limitation of the new Flashpoint API right? |
@SamuelHassine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for antoher issue, works as intended 👍
Thanks for the README + DeprecationWarning example!
stacklevel=2, | ||
) | ||
self.helper.connector_logger.warning(msg) # warns connector user | ||
self.helper.api.work.to_processed(work_id, msg) # warns OpenCTI user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use to_processed() to close the job, it will appear as ‘complete’ on the frontend (for _import_apt and _import_malware). However, other imports such as import_report or import_community based on the same work_id will still be in progress. This can give the impression of a ‘completed’ job when the import is still running in the background. Otherwise the very cool warning (DeprecationWarning
) !
Co-authored-by: Frédéric BASLER <14902945+Megafredo@users.noreply.github.com>
Co-authored-by: Frédéric BASLER <14902945+Megafredo@users.noreply.github.com>
Proposed changes
Flashpoint has deprecated its fp.tools API, resulting in the documents/malware/wiki and documents/apt/wiki endpoints no longer returning data. In response, we are deprecating these options, cleaning up unused code, and updating the documentation accordingly.
Related issues
Checklist
Further comments
This deprecation will not be applied on previous image version : Users of previous versions will not be alerted of this deprecation.