Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crowdstrike] Improve connector and indicators ingestion #2742

Merged
merged 3 commits into from
Oct 2, 2024
Merged

[Crowdstrike] Improve connector and indicators ingestion #2742

merged 3 commits into from
Oct 2, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Oct 1, 2024 •
edited
Loading

Proposed changes

  • Add work_id per entity (Report/Actor/Indicator)
  • Change filter for getting last updated threat actors
  • Change filter for last updated indicators
  • Optimize indicator import

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Oct 1, 2024
@helene-nguyen helene-nguyen self-assigned this Oct 1, 2024
@helene-nguyen helene-nguyen changed the title Opencti/crowdstrike works [Crowdstrike] Improve connector and indicators ingestion Oct 1, 2024
@helene-nguyen helene-nguyen linked an issue Oct 1, 2024 that may be closed by this pull request
[crowdstrike] Push queue message size incorrectly set to 0, disabling buffering/throttling of ingestion #2683
Closed
romain-filigran
romain-filigran approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@romain-filigran romain-filigran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@helene-nguyen helene-nguyen merged commit df16c3d into master Oct 2, 2024
3 checks passed
@helene-nguyen helene-nguyen deleted the opencti/crowdstrike-works branch October 2, 2024 07:50
ulrichzang pushed a commit to cert-orangecyberdefense/connectors that referenced this pull request Oct 24, 2024
@helene-nguyen @romain-filigran @cert-orangecyberdefense
[Crowdstrike] Improve connector and indicators ingestion (OpenCTI-Pla…
4a987bc 
…tform#2742)(issue OpenCTI-Platform#2683)

Co-authored-by: Romain Guignard <romain.guignard@filigran.io>
ulrichzang pushed a commit to cert-orangecyberdefense/connectors that referenced this pull request Oct 24, 2024
@helene-nguyen @romain-filigran @cert-orangecyberdefense
[Crowdstrike] Improve connector and indicators ingestion (OpenCTI-Pla…
355e05a 
…tform#2742)(issue OpenCTI-Platform#2683)

Co-authored-by: Romain Guignard <romain.guignard@filigran.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-filigran romain-filigran romain-filigran approved these changes

@SamuelHassine SamuelHassine Awaiting requested review from SamuelHassine

@richard-julien richard-julien Awaiting requested review from richard-julien

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[crowdstrike] Push queue message size incorrectly set to 0, disabling buffering/throttling of ingestion
2 participants
@helene-nguyen @romain-filigran