Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

[client-python] Remove external reference from mapping cache #695

Merged
helene-nguyen merged 2 commits into from
Jul 8, 2024
Merged

[client-python] Remove external reference from mapping cache #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b778629
[client-python] Remove external reference from mapping cache
helene-nguyen Jul 8, 2024
2adb798
[client-python] Fix lint
helene-nguyen Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pycti/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@
CustomObservableCredential,
CustomObservableCryptocurrencyWallet,
CustomObservableHostname,
CustomObservableMediaContent,
CustomObservablePaymentCard,
CustomObservablePhoneNumber,
CustomObservableText,
CustomObservableTrackingNumber,
CustomObservableUserAgent,
CustomObservableMediaContent,
MultipleRefRelationship,
StixCyberObservableTypes,
StixMetaTypes,
Expand Down
6 changes: 0 additions & 6 deletions pycti/utils/opencti_stix2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,6 @@ def extract_embedded_relationships(
)
if generated_ref_id is None:
continue
if generated_ref_id in self.mapping_cache:
external_reference_id = self.mapping_cache[generated_ref_id]
else:
external_reference_id = self.opencti.external_reference.create(
source_name=source_name,
Expand Down Expand Up @@ -582,7 +580,6 @@ def extract_embedded_relationships(
"no_trigger_import", False
),
)
self.mapping_cache[generated_ref_id] = generated_ref_id
external_references_ids.append(external_reference_id)
if stix_object["type"] in [
"threat-actor",
Expand Down Expand Up @@ -713,8 +710,6 @@ def extract_embedded_relationships(
)
if generated_ref_id is None:
continue
if generated_ref_id in self.mapping_cache:
external_reference_id = self.mapping_cache[generated_ref_id]
else:
external_reference_id = self.opencti.external_reference.create(
source_name=source_name,
Expand Down Expand Up @@ -753,7 +748,6 @@ def extract_embedded_relationships(
mime_type=file["mime_type"],
no_trigger_import=file.get("no_trigger_import", False),
)
self.mapping_cache[generated_ref_id] = generated_ref_id
external_references_ids.append(external_reference_id)
# Granted refs
granted_refs_ids = []
Expand Down